Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12342 )
Change subject: [docker] Adjust Kudu image tagging ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12342/3/docker/README.adoc File docker/README.adoc: http://gerrit.cloudera.org:8080/#/c/12342/3/docker/README.adoc@65 PS3, Line 65: kudu-thirdparty kudu-thirdparty is no longer the right name. Nor is kudu-base below. http://gerrit.cloudera.org:8080/#/c/12342/3/docker/README.adoc@105 PS3, Line 105: images : images: http://gerrit.cloudera.org:8080/#/c/12342/3/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/12342/3/docker/kudu-entrypoint.sh@42 PS3, Line 42: echo "MASTER_ARGS:" : echo " Defines the arguments passed to kudu-master. Defaults to DEFAULT_ARGS" : echo "TSERVER_ARGS:" : echo " Defines the arguments passed to kudu-tserver. Defaults to DEFAULT_ARGS" Maybe more clear as "Defaults to the value of the DEFAULT_ARGS environment variable". http://gerrit.cloudera.org:8080/#/c/12342/3/docker/kudu-entrypoint.sh@48 PS3, Line 48: exit 0 Don't we want a non-zero exit status here? Well, we don't want it if the help was explicitly invoked, but we do if there were no arguments (i.e. a mistake). Maybe the best way to do that would be to pull the setting of the exit status out of print_help() and into its callers. -- To view, visit http://gerrit.cloudera.org:8080/12342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c96a3d5e1ca92022dc614c878f3853a4d99bcb8 Gerrit-Change-Number: 12342 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 03 Feb 2019 19:25:12 +0000 Gerrit-HasComments: Yes
