Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12344 )

Change subject: [docker] Add a kudu user to the kudu image
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12344/2/docker/Dockerfile
File docker/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/12344/2/docker/Dockerfile@222
PS2, Line 222: # Setup the kudu user and create the neccessary directories.
> Does this work properly on all of the distros we support? ISTR groupadd sem
I manually verified this works on centos, debian, and ubuntu.


http://gerrit.cloudera.org:8080/#/c/12344/2/docker/Dockerfile@223
PS2, Line 223: $
> $(...) for new code.
Done


http://gerrit.cloudera.org:8080/#/c/12344/2/docker/README.adoc
File docker/README.adoc:

http://gerrit.cloudera.org:8080/#/c/12344/2/docker/README.adoc@120
PS2, Line 120: "
> What's the significance of this magic string? Is it an image ID?
It is a commit hash, I just meant for it to be an example of a pattern one 
might use. I will remove it in favor of just a *.



--
To view, visit http://gerrit.cloudera.org:8080/12344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d51cf8c6a585f98641de9b91d51e41dec9dbd0
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Feb 2019 00:14:13 +0000
Gerrit-HasComments: Yes

Reply via email to