Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12352/2/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/12352/2/src/kudu/tools/ksck-test.cc@1288 PS2, Line 1288: const string err_str = err_stream_.str(); Thanks for adding a test for that! -- To view, visit http://gerrit.cloudera.org:8080/12352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2 Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 04 Feb 2019 18:01:17 +0000 Gerrit-HasComments: Yes
