Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12377 )
Change subject: KUDU-2411: Remove binary test artifact files on JVM exit ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12377/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java: http://gerrit.cloudera.org:8080/#/c/12377/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java@56 PS1, Line 56: return Files.createTempDirectory(prefix).toFile(); > Perhaps we want this to take a flag for deleteOnExit and add a call to File See my other comment however if you think it's cleaner to register the delete hook from this method based on a boolean flag I'm happy to do that. http://gerrit.cloudera.org:8080/#/c/12377/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java: http://gerrit.cloudera.org:8080/#/c/12377/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java@84 PS1, Line 84: TempDirUtils.registerToRecursivelyDeleteOnShutdown(testTmpDir.toPath()); > Can't we just use File.deleteOnExit() ? That won't work unless the directory is empty on exit: https://stackoverflow.com/questions/15022219/does-files-createtempdirectory-remove-the-directory-after-jvm-exits-normally -- To view, visit http://gerrit.cloudera.org:8080/12377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51701e14eb2f2eb541c04813e74ddc02bf431c3d Gerrit-Change-Number: 12377 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 06 Feb 2019 01:14:18 +0000 Gerrit-HasComments: Yes
