Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12366 )
Change subject: [tools] --load_imbalance_threshold flag for LA rebalancer ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/rebalance_algo.cc File src/kudu/tools/rebalance_algo.cc: http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/rebalance_algo.cc@524 PS1, Line 524: 1.5 > Elsewhere you said 1.67. Why the difference here? I collected more data, i.e. ran more iterations of the test :) Fixed. http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/rebalancer.h File src/kudu/tools/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/rebalancer.h@409 PS1, Line 409: // An instance of the balancing algorithm. : //LocationBalancingAlgo algorithm_; > I guess this can just be removed? Done http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/tool_action_cluster.cc@140 PS1, Line 140: emprically > How did you empirically determine this? I ran the newly added integration tests from https://gerrit.cloudera.org/#/c/11892/ review item. The idea was to see whether the rebalancer stops moving replicas at its second run. I agree that the existence of some 'recommended' value is always questionable, but I think it makes sense to add this threshold for advanced users who might be interested to control the perfect balance vs the cost of replica movement choice. http://gerrit.cloudera.org:8080/#/c/12366/1/src/kudu/tools/tool_action_cluster.cc@140 PS1, Line 140: emprically > empirically Done -- To view, visit http://gerrit.cloudera.org:8080/12366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81867f168dac9908a701b50205be7bfaacefd554 Gerrit-Change-Number: 12366 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 06 Feb 2019 01:54:49 +0000 Gerrit-HasComments: Yes
