Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12372 )
Change subject: KUDU-2676 Support restoring tables over the maximum allowed replicas ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12372/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/12372/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@100 PS1, Line 100: private def createTableRangePartitionByRangePartition( > nit: This is a mouthful. The partition by partition part is an implementati It's a private method. Its existence is an implementation detail. I like the name because it is descriptive. http://gerrit.cloudera.org:8080/#/c/12372/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@108 PS1, Line 108: bounds.headOption.map(bound => { > use foreach instead of map since you don't care about the output. Done http://gerrit.cloudera.org:8080/#/c/12372/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/12372/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@293 PS1, Line 293: def getCreateTableOptions(metadata: TableMetadataPB): CreateTableOptions = { > Not sure if this is used anymore. We could just remove it, or at a minimum Yeah, i guess it's kinda useless, and it easy to implement with what's already there, so I will just remove it. Future people can re-add it if needed. -- To view, visit http://gerrit.cloudera.org:8080/12372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6527d083fc85c25ab0fa7d21cbb339f63374de6 Gerrit-Change-Number: 12372 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 06 Feb 2019 21:03:47 +0000 Gerrit-HasComments: Yes
