Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12275 )
Change subject: KUDU-2674: [java] Add a Java KuduPartitioner API ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12275/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java: http://gerrit.cloudera.org:8080/#/c/12275/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@133 PS4, Line 133: public KuduPartitioner build() throws KuduException { seems to be missing the equivalent of SetBuildTimeout() in the C++ impl http://gerrit.cloudera.org:8080/#/c/12275/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@137 PS4, Line 137: -1 NON_COVERED_RANGE_INDEX http://gerrit.cloudera.org:8080/#/c/12275/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@146 PS4, Line 146: AsyncKuduClient.DEFAULT_OPERATION_TIMEOUT_MS This times the number of partitions could take arbitrarily long so it seems useful to be able to set a timeout on the while series of operations like I mentioned in another comment (since this is intended to be a general-purpose API) http://gerrit.cloudera.org:8080/#/c/12275/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@155 PS4, Line 155: -1 NON_COVERED_RANGE_INDEX This is a bit tricky and I think is worth commenting that if there are non-covered ranges, the start of the non-covered range will have the value of NON_COVERED_RANGE_INDEX while if the range is covered then the start key for the next partition will overwrite the NON_COVERED_RANGE_INDEX value written here. -- To view, visit http://gerrit.cloudera.org:8080/12275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a2d47aab5318c0b6d29a8cb2b073c05bc1b6478 Gerrit-Change-Number: 12275 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 07 Feb 2019 10:07:22 +0000 Gerrit-HasComments: Yes
