Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12371 )

Change subject: [docker] Optimize kudu image size
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12371/3/docker/Dockerfile
File docker/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/12371/3/docker/Dockerfile@142
PS3, Line 142: ARG LINK_TYPE=static
FWIW, this is the default when CMAKE_BUILD_TYPE=release.


http://gerrit.cloudera.org:8080/#/c/12371/3/docker/Dockerfile@180
PS3, Line 180: "/usr/local"
Surprised the client library ends up in /usr/local given that you ran `make 
install` as root. I figured it'd go into /usr/lib64 (or 
/usr/lib/x86_64-linux-gnu).



--
To view, visit http://gerrit.cloudera.org:8080/12371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a1fdad54744a1680d362f59433e94749f35469f
Gerrit-Change-Number: 12371
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:03:21 +0000
Gerrit-HasComments: Yes

Reply via email to