Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12385 )
Change subject: python: fix handling for non-SNAPSHOT versions ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12385/3/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/12385/3/python/setup.py@55 PS3, Line 55: if label is not None and "SNAPSHOT" in label: Nit: this would be more pythonic: if label and "SNAPSHOT" in label: -- To view, visit http://gerrit.cloudera.org:8080/12385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f88a9b9130be38bd6bcb0348454d65e8497a4b2 Gerrit-Change-Number: 12385 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Feb 2019 21:30:23 +0000 Gerrit-HasComments: Yes
