Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12445 )
Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12445/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12445/3//COMMIT_MSG@9 PS3, Line 9: 2e52e7df518d80188c865ea3f7bb3526d14b0c08 > If this is an openssl commit hash, probably not necessary to call it out he Probably, I made it confusing. The commit is the commit that introduced the new threading API. Anyway, I think providing too much details here does not make sense and I'll remove this anyway. http://gerrit.cloudera.org:8080/#/c/12445/3/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/12445/3/src/kudu/security/openssl_util.cc@89 PS3, Line 89: // always initializes its internals for the multi-threaded usage. > Nit: drop 'the' Done http://gerrit.cloudera.org:8080/#/c/12445/3/src/kudu/security/openssl_util.cc@104 PS3, Line 104: for the multi-thread usage > Nit: "for multi-threaded usage" Done http://gerrit.cloudera.org:8080/#/c/12445/3/src/kudu/security/openssl_util.cc@123 PS3, Line 123: OpenSSL > Nit: since you're in the area, could you correct this? Should have said "Op Good catch! Done. http://gerrit.cloudera.org:8080/#/c/12445/3/src/kudu/security/openssl_util.cc@133 PS3, Line 133: // [2] was addressed in OpenSSL 1.1.0i (OPENSSL_VERSION_NUMBER 0x1010009fL). > You can fold this into the "...memory leak in some versions of OpenSSL 1.1. Done -- To view, visit http://gerrit.cloudera.org:8080/12445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7cf22ef81bbeffd25ef2826d925c41b97dc2d8 Gerrit-Change-Number: 12445 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 00:05:59 +0000 Gerrit-HasComments: Yes
