Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12410 )
Change subject: [spark] Factor out the Spark/Kudu row converter ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Probably best to get a +2 from someone more familiar with Scala/Spark. http://gerrit.cloudera.org:8080/#/c/12410/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/12410/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@362 PS1, Line 362: val kuduSchema = table.getSchema : val rowConverter = new RowConverter(kuduSchema, schema, writeOptions.ignoreNull) Combine? -- To view, visit http://gerrit.cloudera.org:8080/12410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89ae6f334134ec47084972c95cfe57a71aa3b68d Gerrit-Change-Number: 12410 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 13 Feb 2019 00:29:46 +0000 Gerrit-HasComments: Yes
