Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12204 )

Change subject: KUDU-2645: schema: Add support for virtual columns in 
projections
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12204/4/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/12204/4/src/kudu/common/schema-test.cc@449
PS4, Line 449:   ASSERT_TRUE(mapped.has_column_ids());
Maybe also assert that 'mapped' isn't equal to 'projection', since 'mapped' 
should has column IDs? Or do you think this about covers that?


http://gerrit.cloudera.org:8080/#/c/12204/4/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:

http://gerrit.cloudera.org:8080/#/c/12204/4/src/kudu/common/schema.cc@402
PS4, Line 402:     if (col.type_info()->is_virtual()) {
Should we DCHECK that, if col is virtual, it explicitly _is not_ in this schema?



--
To view, visit http://gerrit.cloudera.org:8080/12204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06a69ab9d65245e25b1a955765a3a1ebdb9655d3
Gerrit-Change-Number: 12204
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 04:34:05 +0000
Gerrit-HasComments: Yes

Reply via email to