Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12416 )

Change subject: KUDU-2645: schema: Validate that defaults are provided for 
virtual columns
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc@448
PS4, Line 448:   ASSERT_OK(tablet_schema.GetMappedReadProjection(projection, 
&mapped));
Maybe also test that the new error paths are taken given the appropriate input?



--
To view, visit http://gerrit.cloudera.org:8080/12416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 04:35:24 +0000
Gerrit-HasComments: Yes

Reply via email to