Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12393 )
Change subject: [Java] Add PartialRow and RowResult getObject API ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12393/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12393/2//COMMIT_MSG@10 PS2, Line 10: repeting > repeating Done http://gerrit.cloudera.org:8080/#/c/12393/2//COMMIT_MSG@10 PS2, Line 10: Rowresult > RowResult Done http://gerrit.cloudera.org:8080/#/c/12393/2/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/12393/2/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@533 PS2, Line 533: columns > Nit: column's Done http://gerrit.cloudera.org:8080/#/c/12393/2/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@591 PS2, Line 591: case BINARY: return getBinaryCopy(columnIndex); > What's the rationale for getBinaryCopy() over getBinary() in this case? The intent was to be as primitive as possible and safe. This should allow most integrations to use this method. For example Spark handles byte[] but not ByteBuffer. -- To view, visit http://gerrit.cloudera.org:8080/12393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7904a3478896c84fb998d1fddcc2a68c998d4a91 Gerrit-Change-Number: 12393 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 13 Feb 2019 16:43:25 +0000 Gerrit-HasComments: Yes
