Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12477 )

Change subject: log_block_manager: fix invalid pointer
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2063
PS1, Line 2063:   VLOG(3) << "Opened block " << block_id.ToString()
You don't need the ToString() call; there's an operator<< overload for BlockId.


http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2065
PS1, Line 2065:   block->reset(new internal::LogReadableBlock(std::move(lb)));
Hmm, I bet someone reordered this w.r.t. the VLOG. That's an alternative 
solution if you prefer.



--
To view, visit http://gerrit.cloudera.org:8080/12477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a
Gerrit-Change-Number: 12477
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 23:21:37 +0000
Gerrit-HasComments: Yes

Reply via email to