Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12389 )

Change subject: add release notes for 1.9.0
......................................................................


Patch Set 3:

(18 comments)

http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@58
PS3, Line 58: link:TODO[administrative documentation]
> This and a few other links are marked as TODO. What's the remaining work he
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@62
PS3, Line 62: An link:https://hub.docker.com/r/apache/kudu[official
            :   repository] has been created for Apache Kudu Docker artifacts
> Will this be populated prior to the release? It looks empty right now.
That's the idea, yeah.


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@64
PS3, Line 64: People wanting to integrate with Kudu
> Nit: maybe "Kudu integrators"?
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@64
PS3, Line 64: unit
> Nit: drop 'unit'; you can do a Java test at any level.
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@67
PS3, Line 67: This functionality
            :   ships as part of the `kudu-test-utils` Maven module in the 
`MiniCluster`
            :   class. In order for the `MiniCluster` to automatically find the 
appropriate
            :   artifacts when starting up, the `kudu-binary` module must be 
added as a test
            :   time dependency, along with the `kudu-test-utils` module in the 
project’s
            :   Maven or Gradle build.
> Too much implementation detail, I think. Can we link to a more detailed pag
Yeah, this will need some updating based on publishing the binaries.


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@80
PS3, Line 80: cut by a factor of its replication factor.
> I think I wrote this, but can you think of a clearer way to say it? What we
I think this is clear enough as is, though I'll add a note that partitions can 
still be added post-creation, in case less-familiar users are surprised by this 
note.


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@84
PS3, Line 84:   order (see KUDU-1400).
> For this and other JIRAs, could we insert direct links to the JIRAs themsel
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@85
PS3, Line 85: is
> was
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@91
PS3, Line 91: * The Kudu-Spark example can now work against a Kudu cluster with 
a single
            :   tablet server and accepts a custom replication factor as a 
parameter.
> What makes this noteworthy?
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@93
PS3, Line 93: As a part of this upgrade `spark-avro`
            :   was migrated from the Databricks implementation to the 
implementation now
            :   included in Apache Spark. This has been done in an 
API-compatible way.
> This seems like an implementation detail; why do Kudu users care about this
Done, it doesn't affect the user much so I'm removing this.


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@102
PS3, Line 102: is
> has been
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@105
PS3, Line 105: * The amount of server-side logging has been greatly reduced for 
Kudu's
             :   consensus implementation and background processes.
> May want to add a tiny bit of color here. Just to talk about how we removed
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@107
PS3, Line 107: will now more obviously depict
> now more obviously depicts
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@109
PS3, Line 109: is added
> was added
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@112
PS3, Line 112: supporting
             :   very basic predicates
> A bit of color to explain the format in which predicates are described? Or
Done. Also the details are described in the tool's help blurb.


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@121
PS3, Line 121: will now
             :   detect and report
> now detects and reports
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@128
PS3, Line 128: The `--cmeta_force_fsync` flag is introduced to fsync Kudu's 
consensus
             :   metadata more agressively
> The new ... flag may be used to fsync Kudu's consensus metadata more aggres
Done


http://gerrit.cloudera.org:8080/#/c/12389/3/docs/release_notes.adoc@130
PS3, Line 130: improve its handling of
> improve its durability in the face of
Done



--
To view, visit http://gerrit.cloudera.org:8080/12389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc
Gerrit-Change-Number: 12389
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 00:56:44 +0000
Gerrit-HasComments: Yes

Reply via email to