Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12458 )
Change subject: [examples] updated README.md for basic-python-example ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12458/2/examples/python/basic-python-example/README.md File examples/python/basic-python-example/README.md: http://gerrit.cloudera.org:8080/#/c/12458/2/examples/python/basic-python-example/README.md@22 PS2, Line 22: It's assumed the commands below are run from the directory where : this README.md file is located, i.e. from : `$KUDU_HOME/examples/python/basic-python-example` directory. This probably belongs down by "Running the example", right? The commands up here all specify the directory. http://gerrit.cloudera.org:8080/#/c/12458/2/examples/python/basic-python-example/README.md@24 PS2, Line 24: Also, : the recipe requires the Kudu C++ components already built in : `$KUDU_HOME/build/latest`. There's probably a way to merge this with the NOTE below, since it mentions the latest build. -- To view, visit http://gerrit.cloudera.org:8080/12458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103dde66b69db17099b94d66777df37abb4f9fa8 Gerrit-Change-Number: 12458 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Feb 2019 07:22:08 +0000 Gerrit-HasComments: Yes
