Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 )
Change subject: Fix compilation warnings under debian8.9 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12294/3/src/kudu/consensus/leader_election.cc File src/kudu/consensus/leader_election.cc: http://gerrit.cloudera.org:8080/#/c/12294/3/src/kudu/consensus/leader_election.cc@162 PS3, Line 162: #pragma GCC diagnostic push Nit: add a blank line just above this, and the comment "Suppress false positive about 'decision' used while uninitialized." http://gerrit.cloudera.org:8080/#/c/12294/3/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/12294/3/src/kudu/tablet/cfile_set.cc@324 PS3, Line 324: // Disable compilation warnings. Nit: change comment to "Suppress false positive about 'rowid' used when uninitialized." (or 'opt_rowid', if that's where the warning was). -- To view, visit http://gerrit.cloudera.org:8080/12294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2464ff7938f79d090ebd1676da2108ce7dae4ca5 Gerrit-Change-Number: 12294 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 22:28:50 +0000 Gerrit-HasComments: Yes
