Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )
Change subject: [tools] Add tool to list data dirs for a tablet ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692 PS3, Line 692: // Load the tablet meta to make sure the tablet's data directories are loaded : // into the manager. > Ah, so we would get that dir printed in the error message, and everyone can Agh sorry, it would successfully call Load(), but it wouldn't register a group because some of the UUIDs are missing. So the error I think would come from FindDataDirsByTabletId(), saying there is no data dir group for the tablet. IIRC there will be a warning logged about why this is the case, so I think this is fine. -- To view, visit http://gerrit.cloudera.org:8080/12417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff Gerrit-Change-Number: 12417 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 22:56:44 +0000 Gerrit-HasComments: Yes
