Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12522 )
Change subject: Fix some compilation warnings ...................................................................... Patch Set 2: (1 comment) gcc continues to frustrate. By inspection it's clear that these aren't problematic (i.e. an OUT parameter must be set if a RETURN_NOT_OK doesn't return). http://gerrit.cloudera.org:8080/#/c/12522/2/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/12522/2/src/kudu/util/logging.cc@177 PS2, Line 177: if (write(STDERR_FILENO, msg, arraysize(msg)) < 0) { : // Ignore errors. : } Would ignore_result(write(...)) work? See gutil/basictypes.h. -- To view, visit http://gerrit.cloudera.org:8080/12522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia11e3a3ec1b81332aac0b1c841a78d9fb145c33d Gerrit-Change-Number: 12522 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 18:53:49 +0000 Gerrit-HasComments: Yes
