Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12518 )

Change subject: [docker] Use only the kudu binary in the kudu image
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12518/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12518/2//COMMIT_MSG@13
PS2, Line 13: donwloaded
> downloaded
Done


http://gerrit.cloudera.org:8080/#/c/12518/2/docker/Dockerfile
File docker/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/12518/2/docker/Dockerfile@233
PS2, Line 233: COPY --from=build /kudu/build/latest/bin/kudu ./
> Consider adding symlinks for kudu-master and kudu-tserver for folks used to
I don't think I want to try and do this. The behavior is slightly different in 
that the kudu binary expects `master run` to be passed too.

Given the entrypoint hides the details for the common use case and the kudu 
binary has all the functionality, I think this is okay.



--
To view, visit http://gerrit.cloudera.org:8080/12518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I406d18790b17307e9207a5fa67bd733d4689470d
Gerrit-Change-Number: 12518
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Thu, 21 Feb 2019 02:53:31 +0000
Gerrit-HasComments: Yes

Reply via email to