Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12570 )
Change subject: wip KUDU-2353: tool to parse metrics log ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.h File src/kudu/tools/diagnostics_log_parser.h: http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.h@57 PS2, Line 57: explicit ParsedLine(std::string line) > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.h@196 PS2, Line 196: explicit MetricCollectingLogVisitor(MetricsCollectingOpts opts); > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.h@250 PS2, Line 250: const std::string kUnknownSymbol = "<unknown>"; > warning: invalid case style for private member 'kUnknownSymbol' [readabilit Ack http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc File src/kudu/tools/diagnostics_log_parser.cc: http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@47 PS2, Line 47: using std::string; > warning: using decl 'multiset' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@302 PS2, Line 302: RETURN_NOT_OK(VisitMetricsRecord(mr)); > warning: std::move of the const variable 'pl' has no effect; remove std::mo Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@387 PS2, Line 387: } > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@420 PS2, Line 420: VisitSymbolsRecord(sr); > warning: std::move of the const variable 'pl' has no effect; remove std::mo Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@426 PS2, Line 426: VisitStacksRecord(sr); > warning: std::move of the const variable 'pl' has no effect; remove std::mo Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/tools/diagnostics_log_parser.cc@601 PS2, Line 601: return Status::OK(); > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/util/regex.h File src/kudu/util/regex.h: http://gerrit.cloudera.org:8080/#/c/12570/2/src/kudu/util/regex.h@16 PS2, Line 16: bool Match(const std::string& in, std::vector<std::string>* matches) { > warning: the parameter 'in' is copied for each invocation but only used as Done -- To view, visit http://gerrit.cloudera.org:8080/12570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8077fb4f6b41fe4b2bd6c877af379ea7a9f415b1 Gerrit-Change-Number: 12570 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 24 Feb 2019 10:57:28 +0000 Gerrit-HasComments: Yes
