Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12600 )
Change subject: Fix potential duplicate scanner on /scans page ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12600/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/12600/1/src/kudu/tserver/scanners.cc@224 PS1, Line 224: std::unordered_map<string, ScanDescriptor> scans; > Nit: using for this Done http://gerrit.cloudera.org:8080/#/c/12600/1/src/kudu/tserver/scanners.cc@246 PS1, Line 246: vector<ScanDescriptor> ret; : AppendValuesFromMap(scans, &ret); > nit: maybe, add Done -- To view, visit http://gerrit.cloudera.org:8080/12600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I680546d80315a1548337a504c45afa4f2f0350ad Gerrit-Change-Number: 12600 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:18:47 +0000 Gerrit-HasComments: Yes
