Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12279 )
Change subject: KUDU-2543 pt 3 java: pass around authz tokens ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12279/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java: http://gerrit.cloudera.org:8080/#/c/12279/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java@66 PS2, Line 66: KuduSession session = client.newSession(); > IIUC, the different flush modes exercise different code paths though; one u My concern was more about flushing the session at each row, (unintentionally?) producing the behavior of AUTO_FLUSH_SYNC mode regardless of the 'mode' parameter. If you want that behavior for some reason, please add a comment why flushing per row is necessary regardless of the flush mode. http://gerrit.cloudera.org:8080/#/c/12279/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java: http://gerrit.cloudera.org:8080/#/c/12279/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java@71 PS3, Line 71: session.flush(); Still flushing at each row regardless of the 'mode' parameter. Is this intentional? -- To view, visit http://gerrit.cloudera.org:8080/12279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadd5f7709b45628d7ddd9e2b100d0dfaabbf15af Gerrit-Change-Number: 12279 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Feb 2019 17:34:26 +0000 Gerrit-HasComments: Yes
