Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12627 )
Change subject: KUDU-2717. Add an environment variable override for username ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12627/1/src/kudu/util/user.cc File src/kudu/util/user.cc: http://gerrit.cloudera.org:8080/#/c/12627/1/src/kudu/util/user.cc@45 PS1, Line 45: VLOG(1) How often is this function called? Should this be LOG(INFO) to make sure there's a smoking gun in the logs for a case when this is unintentionally set in the environment and it causes problems? -- To view, visit http://gerrit.cloudera.org:8080/12627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d42a3efbf26882f086046c276d5f9965a4068f5 Gerrit-Change-Number: 12627 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 18:22:02 +0000 Gerrit-HasComments: Yes
