Mike Percy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12655


Change subject: WIP: KUDU-2724: Binary jar build on OSX should specify target 
macOS version
......................................................................

WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version

This patch specifies the environment variable MACOSX_DEPLOYMENT_TARGET
when building the binary test jar for macOS in order to specify the
macOS SDK version to build against.

The environment variable is set before calling
thirdparty/build-if-necessary.sh, however there is no logic to detect
whether a previous thirdparty build happened without the environment
variable set.

Maybe this flag should be incorporated into the macOS Kudu build at a
more fundamental level, rather than being tacked onto the binary jar
build script, or perhaps this script should run git clean -xdf
thirdparty or something similar when running on macOS to ensure that we
ship thirdparty shared objects targeted for the intended platform.

Marked as WIP because this patch needs to be tested on a Mac.

Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 14 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12655/1
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>

Reply via email to