Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 )
Change subject: KUDU-2721: support ranges in CPU lists ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12657/9/src/kudu/gutil/sysinfo.cc File src/kudu/gutil/sysinfo.cc: http://gerrit.cloudera.org:8080/#/c/12657/9/src/kudu/gutil/sysinfo.cc@168 PS9, Line 168: // TODO: KUDU-2730: 'present' doesn't include CPUs that could be hotplugged in the > warning: missing username/bug in TODO [google-readability-todo] I guess I'll add myself here. http://gerrit.cloudera.org:8080/#/c/12657/9/src/kudu/gutil/sysinfo.cc@208 PS9, Line 208: numeric_limits<int>::max() > Nit: would be more idiomatic if you used ULONG_MAX here and below, since it I'm checking for int since that's the return type of the function. Added the test cases - good point that I should be covering those branches. -- To view, visit http://gerrit.cloudera.org:8080/12657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97311bfbcf70bea069e941b6e7f4f015fb781b3f Gerrit-Change-Number: 12657 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 23:53:19 +0000 Gerrit-HasComments: Yes
