Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12500 )
Change subject: [sentry] add privilege scope validation to SentryAuthzProvider ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/12500/6/src/kudu/master/sentry_authz_provider.h File src/kudu/master/sentry_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/12500/6/src/kudu/master/sentry_authz_provider.h@90 PS6, Line 90: const std::string& table_ident, > AFAICT this is just a table name; could we name it table_name to be less co Ah, I suggested this change since I recall there being a concept of a table_ident that included the table name and database name. In the context of these functions, those combined comprise the table name. From Kudu's POV table_name is more straight-forward because that's what it is; in the context of Sentry, it might help to know that table_name is expected to include the database name and whatnot. Perhaps a comment would suffice? http://gerrit.cloudera.org:8080/#/c/12500/6/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/12500/6/src/kudu/master/sentry_authz_provider.cc@178 PS6, Line 178: return Status::InvalidArgument("column authorizable scope is not supported " : "for table authorizable type"); This is a contract with developers, not clients -- it'd be a bug if we got here, so perhaps a CHECK is more appropriate? -- To view, visit http://gerrit.cloudera.org:8080/12500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89437a04a4fa18e501d21c3abf5d66a2d22ce58a Gerrit-Change-Number: 12500 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 09 Mar 2019 06:33:25 +0000 Gerrit-HasComments: Yes
