Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 )
Change subject: tserver: correct usage of col idx in SplitKeyRange ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > schema.cc has this in it: > > // In a new schema, we typically would start assigning column IDs at 0. > However, this > // makes it likely that in many test cases, the column IDs and the column > indexes are > // equal to each other, and it's easy to accidentally pass an index where > we meant to pass > // an ID, without having any issues. So, in DEBUG builds, we start > assigning columns at ID > // 10, ensuring that if we accidentally mix up IDs and indexes, we're > likely to fire an > // assertion or bad memory access. > #ifdef NDEBUG > static const ColumnId kFirstColumnId(0); > #else > static const ColumnId kFirstColumnId(10); > #endif > > This tells me that we had no coverage for the SplitKeyRange API, or at least > no coverage for requests with real projections. Is that true? I think so. The feature could certainly use more tests (at the very least I added one at the tserver-level). -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Sun, 10 Mar 2019 02:16:15 +0000 Gerrit-HasComments: No
