Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12715 )
Change subject: [java] Make the KuduScanner iterable ...................................................................... Patch Set 1: The more I think about this, the more I still think it is useful. I assume the optimization is to prevent having 1 object per row result, so sharing the actual data isn't enough. If 1 object pre row isn't a problem this could be fixed. Even if it can't be fixed, we can still make KuduScanner iterable, and it would be just as surprising as RowResult being a shared/unstorable object. Given most uses will implement some form of iteration, I suspect this will prevent more bugs than it will introduce. And of course clear documentation about storage can be added. -- To view, visit http://gerrit.cloudera.org:8080/12715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e4ac59e30d0562c0a381d5e304af1dcfdcf5a1a Gerrit-Change-Number: 12715 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2019 16:55:00 +0000 Gerrit-HasComments: No
