Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 )
Change subject: java: add support for flaky test reporting ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java: http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java@106 PS1, Line 106: private static String tryLookupHostname() { > Where do you see that? The top-voted answer describes how InetAddress.getLo I think that answer is not clear at all about what the code does. It just points out some ways that some particular hostname may not be good in all circumstances while kinda-maybe-sorta hinting that it thinks that the code does DNS. A comment on that answer says if you look at the code it actually does the equivalent of the `hostname` command. The takeaway I got from the entire bunch of answers and comments is that the situation is ¯\_(?)_/¯ and that the way it's done here is the most portable and is somewhat reliable. So we ought to stick with it until it's a problem, I think. -- To view, visit http://gerrit.cloudera.org:8080/12042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f88363dbf52c2f7bba50fbfb5de059f88e7f74 Gerrit-Change-Number: 12042 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2019 21:33:56 +0000 Gerrit-HasComments: Yes
