Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 )
Change subject: authz: verify tokens on scans ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11753/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11753/2/src/kudu/tserver/tablet_service.cc@1495 PS2, Line 1495: if (PREDICT_FALSE(req->has_scanner_id() && > Done Yeah but doesn't the result of LookupRunningTabletReplicaOrRespond leak the existence of a _table_? If you got an authz token for some other table and tried to use it to read a table for which you have no privileges, I imagine you shouldn't even learn that a tablet belonging to that table exists because that means that the table itself exists. -- To view, visit http://gerrit.cloudera.org:8080/11753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5d81cf215a5d936f8853feba05778038764905 Gerrit-Change-Number: 11753 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 12 Mar 2019 21:17:55 +0000 Gerrit-HasComments: Yes
