Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12615 )
Change subject: KUDU-2711 (part 3). Only send one TSInfoPB per server in GetTableLocations ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12615/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12615/1//COMMIT_MSG@12 PS1, Line 12: In the : worst case, this may slightly regress performance if the number of : replicas in the response is much fewer than the number of TS in the : cluster, since there is some extra overhead of building the index : mapping. > Will, could you run this experiment? bin/table_locations-itest --benchmark_num_tablets=1 --benchmark_runtime_secs=30 --gtest_filter="*enchmark*" With this patch: Count: 436196 Mean: 294.595 Percentiles: 0% (min) = 95 25% = 142 50% (med) = 158 75% = 200 95% = 560 99% = 3488 99.9% = 7488 99.99% = 10432 100% (max) = 20694 Without this patch: Count: 446590 Mean: 282.935 Percentiles: 0% (min) = 80 25% = 125 50% (med) = 141 75% = 185 95% = 708 99% = 3392 99.9% = 7296 99.99% = 10304 100% (max) = 20318 So there is a small (~2%) decrease in throughput. http://gerrit.cloudera.org:8080/#/c/12615/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/12615/1/src/kudu/master/master.proto@373 PS1, Line 373: repeated ReplicaPB replicas = 4; > Well, we typically add a "DEPRECATED_" prefix to protobuf fields when we wa I think, since we can't avoid continuing to use this field until a Kudu 2.0, that we should omit DEPRECATED_. Some implementer of a new client will know what to do based on L352. -- To view, visit http://gerrit.cloudera.org:8080/12615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief65d0825e919f681b7ade6a856c103201f8305c Gerrit-Change-Number: 12615 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2019 21:28:37 +0000 Gerrit-HasComments: Yes
