Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12739
to look at the new patch set (#5).
Change subject: [subprocess] use RAW_LOG() in child process
......................................................................
[subprocess] use RAW_LOG() in child process
For a newly fork()-ed, but not yet exec()-ed process, only async-signal
safe functions should be called. At least, glog's LOG() should not be
called since it involves acquiring a lock while flushing the message
into the log sink. Otherwise, the child process can deadlock on attempt
to write a log message if glog's mutex has been copied from the parent's
address space in a locked state.
Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
---
M src/kudu/util/signal.cc
M src/kudu/util/subprocess-test.cc
M src/kudu/util/subprocess.cc
3 files changed, 75 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/12739/5
--
To view, visit http://gerrit.cloudera.org:8080/12739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Gerrit-Change-Number: 12739
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <[email protected]>
