Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12689 )
Change subject: [java] Add private diff scan support ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12689/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/12689/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@54 PS5, Line 54: private static final Logger LOG = LoggerFactory.getLogger(TestScannerMultiTablet.class); This also looks unused. Why is it needed? http://gerrit.cloudera.org:8080/#/c/12689/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java: http://gerrit.cloudera.org:8080/#/c/12689/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java@46 PS5, Line 46: private static final Logger LOG = LoggerFactory.getLogger(TestScannerMultiTablet.class); This looks like an unused private member. Why is it needed here? -- To view, visit http://gerrit.cloudera.org:8080/12689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51b01ae76cd22407df9097b56629ac7262ec2964 Gerrit-Change-Number: 12689 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 14 Mar 2019 20:59:48 +0000 Gerrit-HasComments: Yes
