Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12760
Change subject: Check result status of Socket::GetPeerAddress in TlsSocket::Recv ...................................................................... Check result status of Socket::GetPeerAddress in TlsSocket::Recv Previously, the result of this call wasn't checked, which could lead to, for example, printing out nonsensical and misleading remote addresses, e.g. Network error: BlockingRecv error: failed to read from TLS socket (remote: 0.0.0.0:0): Connection reset by peer (error 104) This patch checks the result status and uses "unknown" for the peer address when it can't be obtained from getpeername: Network error: BlockingRecv error: failed to read from TLS socket (remote: unknown): Connection reset by peer (error 104) Change-Id: Ibd43f30ad11f192463d697f570a997b7e41c7088 --- M src/kudu/security/tls_socket.cc 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12760/1 -- To view, visit http://gerrit.cloudera.org:8080/12760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd43f30ad11f192463d697f570a997b7e41c7088 Gerrit-Change-Number: 12760 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]>
