Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 )
Change subject: [sentry] Integrate AuthzProvider into CatalogManager ...................................................................... Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/cluster_itest_util.h@352 PS12, Line 352: boost::optional<const std::string&> table_id); 'table_locations' is the only OUT parameter so it should come last in the list of args. BTW, you could use a default value here (i.e. boost::none) to avoid having to change all the tests that use this. But then it really will need to come last in the list of args, so it's a trade-off. http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/cluster_itest_util.cc@928 PS12, Line 928: req.mutable_table()->set_table_name(table_name); : if (table_id) { : req.mutable_table()->set_table_id(*table_id); : } Should we enforce that you should only set one of these? Or should we allow for both to be set? http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/hms_itest-base.h File src/kudu/integration-tests/hms_itest-base.h: http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/hms_itest-base.h@54 PS12, Line 54: verifies verifies that http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/hms_itest-base.h@55 PS12, Line 55: // against the logged in user. Missing a closing parens here. http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/11797/12/src/kudu/integration-tests/master_sentry-itest.cc@109 PS12, Line 109: Status GetTableLocationsCore(const string& table, Nit: 'Core' is an unusual suffix here. How about 'WithTableId' or something like that? http://gerrit.cloudera.org:8080/#/c/11797/11/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11797/11/src/kudu/master/catalog_manager.cc@1781 PS11, Line 1781: string table_name = table_identifier.has_table_name() ? : NormalizeTableName(table_identifier.table_name()) : ""; > Are you suggesting to use boost::optional for table_name until L1826? As in Yeah I agree that it won't be optional by the time we hit L1834, but it _is_ optional up until then, and we're implementing that optionality via empty string, which is weird. -- To view, visit http://gerrit.cloudera.org:8080/11797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4aa027ae6eb4520db48ce348db552c9feec2a8 Gerrit-Change-Number: 11797 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 19 Mar 2019 19:24:28 +0000 Gerrit-HasComments: Yes
