Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12783 )
Change subject: [master] introduce cache for location mapping assignments ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12783/1/src/kudu/master/location_cache.cc File src/kudu/master/location_cache.cc: http://gerrit.cloudera.org:8080/#/c/12783/1/src/kudu/master/location_cache.cc@130 PS1, Line 130: Status s = Subprocess::Call(argv, /*stdin_in=*/"", &location_temp, &stderr); > What does this comment /*stdin_in=*/ mean here? Most arguments are self explanatory based on their variable names. In cases where that isn't the case (e.g. passing in nullptr, empty string, etc.), to clarify the callsite, we generally annotate with comments like these indicating what the parameter name is. E.g. from the context here, I can infer that this Subprocess::Call() is doing something like calling argv with nothing as input, and getting out the location (probably as stdout) and some stderr. Otherwise I'd be confused about what this "" is, without looking into the .h file. -- To view, visit http://gerrit.cloudera.org:8080/12783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: Icb5c436c9433acd87c44c4d81982420f33ebb4a4 Gerrit-Change-Number: 12783 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 21:28:16 +0000 Gerrit-HasComments: Yes
