Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12776 )
Change subject: [util] separate generalized CacheMetrics ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG@10 PS2, Line 10: to us > to use Done http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG@10 PS2, Line 10: : > Not seeing LRUCacheMetrics here; was this from a previous approach? Good catch! Done. http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc@465 PS2, Line 465: unique_ptr<FileCacheMetrics> metrics(new FileCacheMetrics(entity)); > It does, but each metric inside a CacheMetrics instance is still bound to j It's a good catch, indeed. I filed KUDU-2749 and included a fix for the issue along with this patch. -- To view, visit http://gerrit.cloudera.org:8080/12776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic77b937e23c600763ec987a96ce98a47ad95ee18 Gerrit-Change-Number: 12776 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Mar 2019 23:54:53 +0000 Gerrit-HasComments: Yes
