Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12796 )
Change subject: [util] renaming entities in cache-related files ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12796/2/src/kudu/util/cache-test.cc File src/kudu/util/cache-test.cc: http://gerrit.cloudera.org:8080/#/c/12796/2/src/kudu/util/cache-test.cc@37 PS2, Line 37: using std::make_tuple; > warning: using decl 'make_tuple' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/12796/2/src/kudu/util/cache-test.cc@299 PS2, Line 299: , LRUCacheTest, > Add name here and below (before the comma). Whoops, it seems I missed this one. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/12796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I963ef41a8097d96fd9530107495dc22066222de4 Gerrit-Change-Number: 12796 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 20 Mar 2019 04:30:04 +0000 Gerrit-HasComments: Yes
