Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12839 )
Change subject: tablet_server-test-base: make types match schema ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12839/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/12839/1/src/kudu/tserver/tablet_server-test.cc@2217 PS1, Line 2217: for (int32_t i = 1; i < 100; i++) { > Nit: this could probably just a regular int as it's a totally unspecial loo Fair point, fixed http://gerrit.cloudera.org:8080/#/c/12839/1/src/kudu/tserver/tablet_server-test.cc@2991 PS1, Line 2991: int32_t warmup = AllowSlowTests() ? > Likewise, seems like a regular int is fine here and for max_rows. Done -- To view, visit http://gerrit.cloudera.org:8080/12839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I209db29d8be884db1173f5141f2e63a89c32d408 Gerrit-Change-Number: 12839 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2019 17:54:09 +0000 Gerrit-HasComments: Yes
