Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 )
Change subject: tablet_service: improve error handling specificity ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12840/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12840/1/src/kudu/tserver/tablet_service.cc@2402 PS1, Line 2402: Status s = PickAndVerifyTimestamp(scan_pb, tablet, &tmp_snap_timestamp); > Right, that's why I added _PREPEND_ in there (though there's no variant for Oh, I missed that part. The name starts to get so dang long. I also am not really convinced this is a prevalent-enough pattern to warrant a helper macro at this time, but would not be against adding it if we thought it would be used a lot. http://gerrit.cloudera.org:8080/#/c/12840/2/src/kudu/util/status.h File src/kudu/util/status.h: http://gerrit.cloudera.org:8080/#/c/12840/2/src/kudu/util/status.h@128 PS2, Line 128: #define RETURN_NOT_OK_CALL KUDU_RETURN_NOT_OK_CALL > Need to remove this. thanks -- To view, visit http://gerrit.cloudera.org:8080/12840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e6f7b01336e78ea8f37cb17b2c4485138e23581 Gerrit-Change-Number: 12840 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2019 22:25:55 +0000 Gerrit-HasComments: Yes
