helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 )
Change subject: KUDU-1711: ColumnSchema supports storing column comment ...................................................................... Patch Set 2: (1 comment) ok, let me try again. http://gerrit.cloudera.org:8080/#/c/12849/2/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/12849/2/src/kudu/client/batcher.cc@a79 PS2, Line 79: My local IWYU complained that this line should be removed but remote IWYU not. -___-## 2019-03-26 19:29:44,171 INFO: Muted IWYU suggestions on 1 file(s) >>> Fixing #includes in >>> '/mnt/ddb/2/helif/apache/kudu/src/kudu/client/batcher.cc' @@ -76,7 +76,6 @@ namespace kudu { -class KuduPartialRow; class Schema; namespace rpc { IWYU would have edited 1 files on your behalf. CMakeFiles/iwyu.dir/build.make:57: recipe for target 'CMakeFiles/iwyu' failed make[3]: *** [CMakeFiles/iwyu] Error 1 -- To view, visit http://gerrit.cloudera.org:8080/12849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d3228100c262cc4a5c63eaf696927c88bc8990 Gerrit-Change-Number: 12849 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2019 11:35:36 +0000 Gerrit-HasComments: Yes
