Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12853 )
Change subject: ksck_remote-test: deflake some more ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12853/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12853/1//COMMIT_MSG@9 PS1, Line 9: some cases : where the consensus state isn't the same across all masters after they are : restarted > Do you have a consensus matrix describing how they differ? Not a consensus matrix, but take a look at http://dist-test.cloudera.org:8080/diagnose?key=704dfc44-4fd0-11e9-8819-0242ac110002. Looks like the added tserver came up during a master election, so I can see why the masters would disagree on the cstate when queried. I don't see anything in the ksck code that retries cstate fetching during an election. I believe this is basically KUDU-2709. http://gerrit.cloudera.org:8080/#/c/12853/1//COMMIT_MSG@11 PS1, Line 11: Maybe this will do the trick? > When I fixed 2748 my testing showed the flakiness went down to 6/2000 failu I looped before and after. I only got 2 failures after, but also only 2 before, which isn't representative of the current flakiness rate as per the flaky test dashboard (nor, anecdotally, of the rate that we seem to still be seeing this failure in precommit). http://gerrit.cloudera.org:8080/#/c/12853/1/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/12853/1/src/kudu/tools/ksck_remote-test.cc@541 PS1, Line 541: n > N Done http://gerrit.cloudera.org:8080/#/c/12853/1/src/kudu/tools/ksck_remote-test.cc@541 PS1, Line 541: cstate > . The Google Style Guide permits comments in a line of code to be less formal[1], which is why I opted for a fragment here. I'll add the capitalization and period, though. 1. https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_Grammar -- To view, visit http://gerrit.cloudera.org:8080/12853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc6c98f91703b52dbf099b1f544a2c70099f35b Gerrit-Change-Number: 12853 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2019 20:51:14 +0000 Gerrit-HasComments: Yes
