Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12865 )
Change subject: dist-test: improve error message when no tests run ...................................................................... Patch Set 1: > Could also move the check and exception into get_tests_execution. Doesn't > matter either way though. I thought about doing that, and it would save a little bit of duplication, but returning an empty list when nothing is found is a reasonable API as well. It seems like a better separation of responsibilities to throw one level above that. -- To view, visit http://gerrit.cloudera.org:8080/12865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3 Gerrit-Change-Number: 12865 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2019 22:58:05 +0000 Gerrit-HasComments: No
