Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 )
Change subject: RELEASING: add instructions to create binary test JARs ...................................................................... Patch Set 1: (2 comments) Looks good! A couple clarifying questions/suggestions http://gerrit.cloudera.org:8080/#/c/12868/1/RELEASING.adoc File RELEASING.adoc: http://gerrit.cloudera.org:8080/#/c/12868/1/RELEASING.adoc@160 PS1, Line 160: # Build a binary JAR for the local operating system. : ./build-support/mini-cluster/build_mini_cluster_binaries.sh : # Sign and publish the JAR to the Maven staging repository used for the Java artifacts (see above). : ./build-support/mini-cluster/publish_mini_cluster_binaries.sh -a=deploy -u="<APACHE-LDAP-USERNAME>" -p="<APACHE-LDAP-PASSWORD>" Probably fine as is, but might also be helpful as a sanity check for people doing this for the first time to add a bit to the comments, details like: "Build a binary JAR for the local operating system. This will generate JAR files in the mini-cluster subdirectory." "Sign and publish the JAR to the Maven staging repository using the Java artifacts. This will publish all Kudu binary JARs, out of the current directory unless otherwise specified (see below)." http://gerrit.cloudera.org:8080/#/c/12868/1/RELEASING.adoc@171 PS1, Line 171: To publish an artifact built by someone else, say on another operating : system, pass the `-j=directory_name` argument to the publish script to : specify the location of the JAR file. Maybe reword as: "To publish an artifact outside of the `mini-cluster` directory, e.g. because it was built by someone else on another OS, pass the `-j=directory_name` argument to the publishing script to specify the location of the JAR file." Also, does the user need to be careful about what the contents of directory_name are? Eg do they need to make sure there are no other JAR files in the directory, say if this were a Downloads folder? Or will the script only detect JARs built by the build script? -- To view, visit http://gerrit.cloudera.org:8080/12868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c0419b666fe8dfa9394136962189eee97af2d38 Gerrit-Change-Number: 12868 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 27 Mar 2019 01:07:00 +0000 Gerrit-HasComments: Yes
