Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@33 PS1, Line 33: // errorprone 2.3.2+ has an issue on older JDKs see May want to clarify that this is specifically about old JDK8 versions, so that if/when we drop JDK8 support we'll know this can be upgraded. Or is this no longer an issue now that error prone is using its own javac? http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@36 PS1, Line 36: errorProneJavac: "9+181-r4173-1", So this is a full-fledged JDK of sorts? Is it a native dependency? -- To view, visit http://gerrit.cloudera.org:8080/12869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2 Gerrit-Change-Number: 12869 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Mar 2019 17:49:31 +0000 Gerrit-HasComments: Yes
