Hello Will Berkeley, Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12875
to review the following change.
Change subject: java: fix tests that use ExpectedException
......................................................................
java: fix tests that use ExpectedException
There's a weird interaction between the ExpectedException and
KuduTestHarness rules. The test passes, but the RetryRule embedded in
KuduTestHarness thinks it failed and reports a test failure. It has
something to do with the assumptions JUnit has around state; reinvoking a
test method violates those assumptions.
Anyway, the solution is to use a RuleChain to set up the two rules. In the
case of TestAsyncUtil, we didn't even need the ExpectedException at all.
Change-Id: Iddba2ccfac5a3120c111d25f5cfefae22292c5f4
---
M
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M
java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
3 files changed, 17 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12875/1
--
To view, visit http://gerrit.cloudera.org:8080/12875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddba2ccfac5a3120c111d25f5cfefae22292c5f4
Gerrit-Change-Number: 12875
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
