Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test ...................................................................... Patch Set 1: > I thought about doing this when the RetryRule was introduced, but left it off > of these tests because there really is no way they could be flaky. They don't > talk to an external service and they don't depending on tricky things like > timing. They are just pure in/out unit tests. >From a reporting standpoint, we absolutely want every single test to report >in. Besides parity with the C++ reporting infrastructure, comprehensive data >collection could open up new dashboard use cases in the future. For example, >maybe we want to get a sense for how many times a day a given test runs. I'm willing to grant that these simple tests may not need _retrying_ (though I'm skeptical about that: show me your algorithm that _proves_ whether a test can be flaky or not). However, the coupling of ResultReporter and RetryRule makes it impractical to get the former without the latter (i.e. converting ResultReporter into a @Rule just to handle these cases doesn't seem worthwhile to me). Also, this makes the guidance for adding new Java tests really straight-forward: add the KuduTestHarness rule if you need a minicluster; otherwise, add the RetryRule rule. There are no exceptions. -- To view, visit http://gerrit.cloudera.org:8080/12872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5 Gerrit-Change-Number: 12872 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2019 03:41:59 +0000 Gerrit-HasComments: No
