Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 )
Change subject: KUDU-1711: ColumnSchema supports storing column comment ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/12849/8/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/12849/8/src/kudu/client/schema.h@288 PS8, Line 288: const boost::optional<std::string>* comment = NULL); > warning: use nullptr [modernize-use-nullptr] We can't use nullptr in code that needs to compile with pre-C++11 compilers, so in order to pacify clang-tidy please add a //NOLINT(modernize-use-nullptr) as was done for default_value. But, please see my earlier feedback: since you've converted this into a pointer, there's no more need for boost::optional; the pointer itself expresses the optionality via its nullability. -- To view, visit http://gerrit.cloudera.org:8080/12849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d3228100c262cc4a5c63eaf696927c88bc8990 Gerrit-Change-Number: 12849 Gerrit-PatchSet: 8 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2019 20:08:44 +0000 Gerrit-HasComments: Yes
